gitea
122480cd46
Brings in the A4 (millimetre) report designer alongside the existing matrix editor, migrates the frontend from react-scripts to Vite/Vitest, and fixes four defects found while using the A4 band tools. Layout — layout.js now implements the standard banded-report model: everything prints where it was drawn, and a band growing per data row is the only thing that moves anything. Previously `paginate` re-flowed every band from the top margin, so a band placed halfway down the page previewed at the top, and `header` was treated as a page header and hoisted above the statics drawn before it. A header is a COLUMN header: it prints in place and repeats only on a continuation page. Statics now take part too — one drawn below a band keeps its drawn gap as that band grows, and follows onto the next page rather than vanishing when pushed past the bottom margin. The displacement is keyed on the band's design bottom, not on an instance's laid-out y: every row of a band shares one design position, so keying on the instance measured the gap from row 1 and let the static overlap rows 2..n. Band children — a child's x is relative to its band, as its y already was. layout() emitted it raw, so a field printed measured from the paper edge instead of the band's left margin. Instances now carry bandX. Band placement — a band's x comes from the page margins, so creation takes only the click's Y (the factory's x was being overwritten by the spread order) and dragging is locked to the vertical axis. Bands render as a strip, with top/bottom rules only, matching the matrix editor. fromApiReport reflows on load so reports saved with a stray x straighten themselves. Matrix bands are constrained to vertical too. Drag lifecycle — useElementDrag re-subscribed its document listeners on every render during a drag, because the effect depended on an unmemoized onDrag. Each re-subscribe removed the mouseup listener before adding the next, measured as add/remove/add/remove/add across two mousemoves, and a release landing in that gap was lost: the element kept following the cursor until the next click. Snapping made it routine, since a held guide stops x/y changing and leaves the guide overlay's render sitting between the move and the release. onDrag and dragData now go through refs so the effect depends on [isDragging] alone. Note: the matrix editor has no test coverage, so its band constraint is verified by reading only. The A4 suite is 201 passing tests. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
1.5 KiB
Decimal / float number inputs
Rule: for a field where the user types a decimal value (millimetres, rates, any float),
use type="text" + inputMode="decimal" with local draft-string state — not
type="number".
Why
Two independent failure modes combine:
-
type="number"sanitises partial input. While the user is typing12.7, the intermediate value is"12.", which is not a valid number. The browser (and jsdom) reportinput.value === "". The decimal point appears not to type at all. -
A naive
parseFloat+isNaNguard drops the same intermediate.parseFloat("12.")is12, so a commit-on-every-change handler rewrites the field to"12"and the caret jumps — same visible symptom, different cause.
The working pattern
Keep the raw string in local state while focused; commit only when it parses cleanly; re-sync from the prop only when not focused (so drag/resize updates still flow in).
const [draft, setDraft] = useState(String(value ?? ''));
const [isFocused, setIsFocused] = useState(false);
useEffect(() => {
if (!isFocused) setDraft(String(value ?? ''));
}, [value, isFocused]);
// onChange: setDraft(next) always; commit only if next is a complete number
// onBlur: if the draft is empty/unparseable, restore String(value); else commit rounded
Reference implementation: MmInput in
frontend/src/components/ReportEditor/a4/A4Inspector.jsx.
Note the matrix editor's ObjectInspector.jsx uses parseInt and integer cells, so it
does not need this — only float-valued fields do.