gitea
122480cd46
Brings in the A4 (millimetre) report designer alongside the existing matrix editor, migrates the frontend from react-scripts to Vite/Vitest, and fixes four defects found while using the A4 band tools. Layout — layout.js now implements the standard banded-report model: everything prints where it was drawn, and a band growing per data row is the only thing that moves anything. Previously `paginate` re-flowed every band from the top margin, so a band placed halfway down the page previewed at the top, and `header` was treated as a page header and hoisted above the statics drawn before it. A header is a COLUMN header: it prints in place and repeats only on a continuation page. Statics now take part too — one drawn below a band keeps its drawn gap as that band grows, and follows onto the next page rather than vanishing when pushed past the bottom margin. The displacement is keyed on the band's design bottom, not on an instance's laid-out y: every row of a band shares one design position, so keying on the instance measured the gap from row 1 and let the static overlap rows 2..n. Band children — a child's x is relative to its band, as its y already was. layout() emitted it raw, so a field printed measured from the paper edge instead of the band's left margin. Instances now carry bandX. Band placement — a band's x comes from the page margins, so creation takes only the click's Y (the factory's x was being overwritten by the spread order) and dragging is locked to the vertical axis. Bands render as a strip, with top/bottom rules only, matching the matrix editor. fromApiReport reflows on load so reports saved with a stray x straighten themselves. Matrix bands are constrained to vertical too. Drag lifecycle — useElementDrag re-subscribed its document listeners on every render during a drag, because the effect depended on an unmemoized onDrag. Each re-subscribe removed the mouseup listener before adding the next, measured as add/remove/add/remove/add across two mousemoves, and a release landing in that gap was lost: the element kept following the cursor until the next click. Snapping made it routine, since a held guide stops x/y changing and leaves the guide overlay's render sitting between the move and the release. onDrag and dragData now go through refs so the effect depends on [isDragging] alone. Note: the matrix editor has no test coverage, so its band constraint is verified by reading only. The A4 suite is 201 passing tests. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
36 lines
1.8 KiB
Markdown
36 lines
1.8 KiB
Markdown
---
|
|
name: a4-print-path
|
|
description: Two non-obvious constraints in the A4 report print path — the print-root must be a direct body child, and flushSync (not rAF) must precede window.print()
|
|
metadata:
|
|
type: project
|
|
---
|
|
|
|
Two constraints in `frontend/src/components/ReportEditor/a4/print/` that are easy to
|
|
silently break and whose failure mode is a blank or wrong printed page.
|
|
|
|
**1. `.print-root` must sit on the element appended directly to `<body>`.**
|
|
`print.css` hides the app with `body > *:not(.print-root)` — a CHILD combinator. The app
|
|
mounts into `<div id="root">`, itself a direct body child, so the print container is its
|
|
sibling. If the class lived only on `PrintDocument`'s inner div, the appended container
|
|
would match the hiding rule and print a blank page.
|
|
|
|
**Why:** the selector is the entire mechanism for hiding the editor during print; there is
|
|
no other switch.
|
|
**How to apply:** when changing how the print container mounts, keep the class on the
|
|
container itself. `printReport.js` sets it; `PrintDocument` repeats it for the standalone
|
|
case.
|
|
|
|
**2. `flushSync` — never `requestAnimationFrame` — before `window.print()`.**
|
|
`window.print()` reads the DOM synchronously while React 18 commits asynchronously, so an
|
|
unflushed render prints an empty container. rAF was the first fix tried and is wrong: it
|
|
does not fire in a background or hidden tab, so a print click would hang instead of
|
|
printing.
|
|
|
|
**Why:** discovered when tests showed `window.print` never being reached behind a
|
|
double-rAF await; the background-tab case is the production version of the same bug.
|
|
**How to apply:** any new print entry point wraps its `root.render` in `flushSync` from
|
|
`react-dom`.
|
|
|
|
Related: `.a4-print-page` is deliberately NOT `.a4-page` — `A4Canvas.css` already owns
|
|
`.a4-page` for the on-screen editor canvas, and both stylesheets load together.
|